[webkit-reviews] review granted: [Bug 194220] [MSE][GStreamer] Batch player duration updates : [Attachment 362607] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted  review:
Bug 194220: [MSE][GStreamer] Batch player duration updates
https://bugs.webkit.org/show_bug.cgi?id=194220

Attachment 362607: Patch

https://bugs.webkit.org/attachment.cgi?id=362607&action=review




--- Comment #14 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 362607
  --> https://bugs.webkit.org/attachment.cgi?id=362607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362607&action=review

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.c
pp:680
> +    m_durationChangedWhileBlocked = false;

You can do this inside the if.

>
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h
:118
> +    bool m_blockingDurationChanges = false;
> +    bool m_durationChangedWhileBlocked = false;

m_areDurationChangesBlocked and m_shouldReportDurationWhenUnblocking