[webkit-reviews] review denied: [Bug 191645] [Curl] Implement Cookie Accept Policy. : [Attachment 362684] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 22 01:22:27 PST 2019


Fujii Hironori <Hironori.Fujii at sony.com> has denied Takashi Komori
<Takashi.Komori at sony.com>'s request for review:
Bug 191645: [Curl] Implement Cookie Accept Policy.
https://bugs.webkit.org/show_bug.cgi?id=191645

Attachment 362684: Patch

https://bugs.webkit.org/attachment.cgi?id=362684&action=review




--- Comment #26 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 362684
  --> https://bugs.webkit.org/attachment.cgi?id=362684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362684&action=review

> Source/WebCore/platform/network/curl/CookieUtil.cpp:88
> +    auto index = host.reverseFind(domain);

You should use String.endsWith.


More information about the webkit-reviews mailing list