[webkit-reviews] review granted: [Bug 194703] Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction : [Attachment 362205] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 194703: Input type "formatSetInlineTextDirection" is dispatched when
changing paragraph-level text direction
https://bugs.webkit.org/show_bug.cgi?id=194703

Attachment 362205: Patch

https://bugs.webkit.org/attachment.cgi?id=362205&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 362205
  --> https://bugs.webkit.org/attachment.cgi?id=362205
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362205&action=review

> Source/WebCore/editing/EditAction.cpp:78
> +    case EditAction::SetTextWritingDirection:
> +    case EditAction::SetBaseWritingDirection:

I would have preferred using inline & block to match input type names.