[webkit-reviews] review granted: [Bug 194895] Incorrect use of String::foldCase for font family names : [Attachment 362591] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 19:35:50 PST 2019


Myles C. Maxfield <mmaxfield at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 194895: Incorrect use of String::foldCase for font family names
https://bugs.webkit.org/show_bug.cgi?id=194895

Attachment 362591: Patch

https://bugs.webkit.org/attachment.cgi?id=362591&action=review




--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 362591
  --> https://bugs.webkit.org/attachment.cgi?id=362591
Patch

Looks good. https://drafts.csswg.org/css-fonts-4/#localized-name-matching says
font names can be non-ascii but it looks like this code handles that case
correctly.


More information about the webkit-reviews mailing list