[webkit-reviews] review granted: [Bug 194835] Reduce use of LegacySync IPC message type : [Attachment 362444] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194835: Reduce use of LegacySync IPC message type
https://bugs.webkit.org/show_bug.cgi?id=194835

Attachment 362444: Patch

https://bugs.webkit.org/attachment.cgi?id=362444&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 362444
  --> https://bugs.webkit.org/attachment.cgi?id=362444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362444&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:464
> +    completionHandler(result.first, result.second);

I think WTFMove(result.first) would save a tiny bit of reference count churn.

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:487
> +    completionHandler(result.first, result.second);

I think WTFMove(result.first) would save a tiny bit of reference count churn.

> Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:254
> +	   return completionHandler(false);

There it is, one of those return void things.

> Source/WebKit/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:261
> +    completionHandler(true);

But no return here. What about if you refactor and add a return value? (Just
kidding.)