[webkit-reviews] review requested: [Bug 194924] REGRESSION(PSON) Scroll position is sometimes not restored on history navigation : [Attachment 362671] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 194924: REGRESSION(PSON) Scroll position is sometimes not restored on
history navigation
https://bugs.webkit.org/show_bug.cgi?id=194924

Attachment 362671: Patch

https://bugs.webkit.org/attachment.cgi?id=362671&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 362671
  --> https://bugs.webkit.org/attachment.cgi?id=362671
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362671&action=review

Not sure why the r-

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2710
>> +	SetForScope<void (*)(WebCore::HistoryItem&)>
bypassHistoryItemUpdateNotifications(WebCore::notifyHistoryItemChanged,
ignoreHistoryItemUpdates);
> 
> ignoreHistoryItemUpdates could be replaced by my favorite lambda [](auto){}

Will this work even though it expects a function pointer?