[webkit-reviews] review granted: [Bug 194913] [MSVC] Fix compilation errors with lambdas in ResourceLoadStatistics : [Attachment 362628] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 194913: [MSVC] Fix compilation errors with lambdas in
ResourceLoadStatistics
https://bugs.webkit.org/show_bug.cgi?id=194913

Attachment 362628: Patch

https://bugs.webkit.org/attachment.cgi?id=362628&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 362628
  --> https://bugs.webkit.org/attachment.cgi?id=362628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362628&action=review

EWS seems happy, so this change looks good.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:3
69
> +	   RunLoop::main().dispatch([this, weakThis = WTFMove(weakThis)]() {

Interesting that MSVC doesn't like this. This actually seems like better code
anyway.

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:33
> +#include "NetworkProcess.h"

I wonder if this was missing because of the vagaries of our Unified Sources
behavior.