[webkit-reviews] review granted: [Bug 194911] Add more doesGC() assertions. : [Attachment 362645] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 21 14:24:31 PST 2019
Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 194911: Add more doesGC() assertions.
https://bugs.webkit.org/show_bug.cgi?id=194911
Attachment 362645: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=362645&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362645
--> https://bugs.webkit.org/attachment.cgi?id=362645
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=362645&action=review
> Source/JavaScriptCore/ChangeLog:47
> + (JSC::Heap::collectAsync):
I wonder if it's correct for this one.
> Source/JavaScriptCore/heap/DeferGC.h:49
> + if (m_heap.deferralDepth() == 1)
Why would we not always assert this? We generally don't know if we're the
outmost or not.
> Source/JavaScriptCore/heap/Heap.cpp:1033
> + RELEASE_ASSERT(expectDoesGC());
I wonder if this should be based on synchronousness
More information about the webkit-reviews
mailing list