[webkit-reviews] review granted: [Bug 194861] API::HTTPCookieStore should expose setCookies() : [Attachment 362637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 13:24:26 PST 2019


Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194861: API::HTTPCookieStore should expose setCookies()
https://bugs.webkit.org/show_bug.cgi?id=194861

Attachment 362637: Patch

https://bugs.webkit.org/attachment.cgi?id=362637&action=review




--- Comment #13 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 362637
  --> https://bugs.webkit.org/attachment.cgi?id=362637
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362637&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:1336
> +    WTFLogAlways("SAFE BROWSING ENABLED");

Was this meant to be included in this patch?

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:83
> +	       WTFLogAlways("SAFE BROWSING FRAMEWORK COMPLETION HANDLER CALLED
%@ %@", result.get(), error.get());

Was this meant to be included in this patch?


More information about the webkit-reviews mailing list