[webkit-reviews] review canceled: [Bug 184987] [Cocoa] ResourceRequest constructors should retain 'isTopSite' (and other) state : [Attachment 338798] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 21 10:14:58 PST 2019

Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 184987: [Cocoa] ResourceRequest constructors should retain 'isTopSite' (and
other) state

Attachment 338798: Patch


--- Comment #12 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 338798
  --> https://bugs.webkit.org/attachment.cgi?id=338798

Declaring bankruptcy on this bug. Fix is correct and Claudio Saavedra is the
only person that could figure this out. I suspect the confusion arose because I
thought I could kill two birds with one stone with this bug: 1) fix the
correctness issue myself and Claudio noticed and 2) provide an enhancement for
Brent to use (see the request in comment #0). It would later turn out that
Brent would not need this enhancement as he forged his own equivalent,
NetworkLoadParameters.isMainFrameNavigation (as pointed out in comment #10).
Untangling this mess by reverting the name of the bug back to its original name
and closing it.

More information about the webkit-reviews mailing list