[webkit-reviews] review granted: [Bug 194885] Web Inspector: macOS user agent option should be available in device settings menu : [Attachment 362586] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 194885: Web Inspector: macOS user agent option should be available in
device settings menu
https://bugs.webkit.org/show_bug.cgi?id=194885

Attachment 362586: Patch

https://bugs.webkit.org/attachment.cgi?id=362586&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 362586
  --> https://bugs.webkit.org/attachment.cgi?id=362586
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362586&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:2074
> +	       { name: "Safari 12.2", value: "Mozilla/5.0 (Macintosh; Intel Mac
OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.2
Safari/605.1.15" },

I'm not sure 10_14_4 is the current shipping but that part isn't the most
important bit, the rest are.

> Source/WebInspectorUI/UserInterface/Base/Main.js:2076
> +	   ],
>	   [

Why separate this from the other Safaris? I think it makes sense to put all the
Safari's together, Mac, iPhone, iPad.
We could even consider a watchOS UserAgent.