[webkit-reviews] review granted: [Bug 194845] Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process : [Attachment 362574] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 194845: Crash under RemoteLayerTreePropertyApplier::applyProperties when
reattaching to old process
https://bugs.webkit.org/show_bug.cgi?id=194845

Attachment 362574: Patch

https://bugs.webkit.org/attachment.cgi?id=362574&action=review




--- Comment #18 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 362574
  --> https://bugs.webkit.org/attachment.cgi?id=362574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362574&action=review

> Source/WebCore/page/PageOverlayController.cpp:253
> +    for (auto& overlay : m_pageOverlays) {
> +	   if (auto optionalLayer =
m_overlayGraphicsLayers.take(overlay.get()))
> +	       optionalLayer.value()->removeFromParent();
> +
> +	   overlay->willReattachToPage(&m_page);

If an overlay triggers mutation of m_pageOverlays inside willReattachToPage()
bad things will happen

> Source/WebCore/page/PageOverlayController.cpp:259
> +	   installLayerForOverlay(*overlay);

Does this call into overlay code that could mutate m_pageOverlays?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PageOverlayPlugin.mm:61
> +
> +

Two blank lines.