[webkit-reviews] review granted: [Bug 194601] REGRESSION: [ iOS ] Layout Test editing/input/ios/rtl-keyboard-input-on-focus.html is a Timeout : [Attachment 362531] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 14:42:59 PST 2019


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 194601: REGRESSION: [ iOS ] Layout Test
editing/input/ios/rtl-keyboard-input-on-focus.html is a Timeout
https://bugs.webkit.org/show_bug.cgi?id=194601

Attachment 362531: Patch

https://bugs.webkit.org/attachment.cgi?id=362531&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 362531
  --> https://bugs.webkit.org/attachment.cgi?id=362531
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362531&action=review

>
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
514
> +    for (const auto& callbackID : callbackIDs)
> +	   m_webPage.send(Messages::WebPageProxy::VoidCallback(callbackID));

These are going to beat the transaction, which seems bad (maybe not in this
case, but for people expecting the callbacks to mean what they mean in the
non-UI-side world).


More information about the webkit-reviews mailing list