[webkit-reviews] review granted: [Bug 194872] Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked : [Attachment 362541] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 20 14:36:52 PST 2019


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 194872: Regression(PSON) "Reload without content extensions" does not work
when the main resource is blocked
https://bugs.webkit.org/show_bug.cgi?id=194872

Attachment 362541: Patch

https://bugs.webkit.org/attachment.cgi?id=362541&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 362541
  --> https://bugs.webkit.org/attachment.cgi?id=362541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362541&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:4875
> +    [[WKContentRuleListStore defaultStore]
removeContentRuleListForIdentifier:@"ContentBlockingAfterProcessSwapExtension"
completionHandler:^(NSError *error) {

Can we do this at the end of the test to prevent the state from leaking into
other tests?


More information about the webkit-reviews mailing list