[webkit-reviews] review granted: [Bug 193938] We should add code to validate expected GC activity modelled by doesGC() against what the runtime encounters. : [Attachment 362432] proposed patch.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 193938: We should add code to validate expected GC activity modelled by
doesGC() against what the runtime encounters.
https://bugs.webkit.org/show_bug.cgi?id=193938

Attachment 362432: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=362432&action=review




--- Comment #8 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 362432
  --> https://bugs.webkit.org/attachment.cgi?id=362432
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=362432&action=review

r=me

> Source/JavaScriptCore/runtime/JSString.h:575
> +    if (allocationAllowed) {
> +	   if (validateDFGDoesGC)
> +	       RELEASE_ASSERT(vm()->heap.expectDoesGC());

Shouldn't these checks and assert be inside the isRope() then code?  If this
string isn't a rope, we don't care about these checks.