[webkit-reviews] review denied: [Bug 194709] IndexedDB: IDBDatabase and IDBTransaction are leaked in layout tests : [Attachment 362504] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 194709: IndexedDB: IDBDatabase and IDBTransaction are leaked in layout
tests
https://bugs.webkit.org/show_bug.cgi?id=194709

Attachment 362504: Patch

https://bugs.webkit.org/attachment.cgi?id=362504&action=review




--- Comment #27 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 362504
  --> https://bugs.webkit.org/attachment.cgi?id=362504
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362504&action=review

> Source/WebCore/testing/Internals.cpp:2390
> +    return IDBTransaction::allIDBTransactions().size();

Still not safe since you're accessing the map without locking here.

> LayoutTests/storage/indexeddb/IDBObject-leak.html:6
> +

jsTestIsAsync = true;

> LayoutTests/storage/indexeddb/IDBObject-leak.html:30
> +	   testRunner.waitUntilDone();

You should not use this since you're using js-test and finishJSTest().

> LayoutTests/storage/indexeddb/IDBObject-leak.html:34
> +	   }), 1);

Why 1?