[webkit-reviews] review granted: [Bug 167941] [WPE][GTK] Enable support for CONTENT_EXTENSIONS : [Attachment 362419] Patch v12

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 167941: [WPE][GTK] Enable support for CONTENT_EXTENSIONS
https://bugs.webkit.org/show_bug.cgi?id=167941

Attachment 362419: Patch v12

https://bugs.webkit.org/attachment.cgi?id=362419&action=review




--- Comment #88 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 362419
  --> https://bugs.webkit.org/attachment.cgi?id=362419
Patch v12

View in context: https://bugs.webkit.org/attachment.cgi?id=362419&action=review

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp:84
> +	  
assertObjectIsDeletedWhenTestFinishes(G_OBJECT(m_filterStore.get()));

This is already done in newStore().

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:452
> +    WebKitUserContentFilterStore* store =
webkit_user_content_filter_store_new(filtersPath.get());

test->assertObjectIsDeletedWhenTestFinishes()

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:458
> +    Data data { g_main_loop_ref(test->m_mainLoop), nullptr, };

You don't need to ref the main loop.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:471
> +    g_main_loop_unref(data.mainLoop);

And you don't need to unref it here either.