[webkit-reviews] review granted: [Bug 194836] [bmalloc] bmalloc::Heap is allocated even though we use system malloc mode : [Attachment 362482] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194836: [bmalloc] bmalloc::Heap is allocated even though we use system
malloc mode
https://bugs.webkit.org/show_bug.cgi?id=194836

Attachment 362482: Patch

https://bugs.webkit.org/attachment.cgi?id=362482&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362482
  --> https://bugs.webkit.org/attachment.cgi?id=362482
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362482&action=review

r=me.  Can you run PerformanceTests/MallocBench just to be sure that there's no
significant perf difference?

> Source/bmalloc/bmalloc/bmalloc.cpp:71
> +	   {
> +	       std::unique_lock<Mutex> lock(Heap::mutex());
> +	       result = heap.tryAllocateLarge(lock, alignment, size);
> +	       if (result) {
> +		   // Don't track this as dirty memory that dictates how we
drive the scavenger.
> +		   // FIXME: We should make it so that users of this API inform
bmalloc which
> +		   // pages they dirty:
> +		   // https://bugs.webkit.org/show_bug.cgi?id=184207
> +		   heap.externalDecommit(lock, result, size);
> +	       }
>	   }

No need to indent one more level here.	You're already inside a scope unlike
before.