[webkit-reviews] review denied: [Bug 194796] Web Inspector: Styles: Control-Space should force completion : [Attachment 362349] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 20:37:46 PST 2019

Matt Baker <mattbaker at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 194796: Web Inspector: Styles: Control-Space should force completion

Attachment 362349: Patch


--- Comment #8 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 362349
  --> https://bugs.webkit.org/attachment.cgi?id=362349

r- for now, because completions for property values are currently broken,
making this difficult to review.

The completions popover is no longer shown when tabbing to a new property value
from a property name. This regressed in https://webkit.org/b/193605. I think it
makes sense to fix the behavior as part of this patch, since they are so
closely related.

More information about the webkit-reviews mailing list