[webkit-reviews] review granted: [Bug 194761] Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator : [Attachment 362389] Patch v3

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 194761: Leak of CFErrorRef objects (1.92 Kbytes) in
com.apple.WebKit.WebContent.Development running WebKit layout tests  on iOS
Simulator
https://bugs.webkit.org/show_bug.cgi?id=194761

Attachment 362389: Patch v3

https://bugs.webkit.org/attachment.cgi?id=362389&action=review




--- Comment #17 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 362389
  --> https://bugs.webkit.org/attachment.cgi?id=362389
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=362389&action=review

> Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:92
> +		   if (!CTFontManagerRegisterFontsForURL((CFURLRef)fontURL,
kCTFontManagerScopeProcess, &error)) {

Shouldn't we be using C++-style casts?

> Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:147
> +	   // Registering shadow fonts is only supported on macOS Mojave or
newer. See Bugs 180062 & 194761.

I think it's supposed to work on iOS, but we shouldn't block this patch on
that. We can open a new bug to investigate why it doesn't work on iOS.