[webkit-reviews] review granted: [Bug 194625] B3-O2 incorrectly optimizes this subtest : [Attachment 362428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 14:24:32 PST 2019


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 194625: B3-O2 incorrectly optimizes this subtest
https://bugs.webkit.org/show_bug.cgi?id=194625

Attachment 362428: Patch

https://bugs.webkit.org/attachment.cgi?id=362428&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362428
  --> https://bugs.webkit.org/attachment.cgi?id=362428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362428&action=review

r=me

> Source/JavaScriptCore/b3/testb3.cpp:3537
> +	   root->appendNew<Const32Value>(proc, Origin(), 1),

Can you add a test that would have done the wrong in thing in B3-O2 before?


More information about the webkit-reviews mailing list