[webkit-reviews] review granted: [Bug 194799] [JSC] Introduce JSNonDestructibleProxy for JavaScriptCore.framework's GlobalThis : [Attachment 362354] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 11:23:55 PST 2019


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194799: [JSC] Introduce JSNonDestructibleProxy for
JavaScriptCore.framework's GlobalThis
https://bugs.webkit.org/show_bug.cgi?id=194799

Attachment 362354: Patch

https://bugs.webkit.org/attachment.cgi?id=362354&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362354
  --> https://bugs.webkit.org/attachment.cgi?id=362354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362354&action=review

> Source/JavaScriptCore/runtime/JSNonDestructibleProxy.cpp:2
> + * Copyright (C) 2011-2012, 2016-2017 Apple Inc. All rights reserved.

2019

> Source/JavaScriptCore/runtime/JSNonDestructibleProxy.h:41
> +	   return JSNonFinalObject::subspaceFor<CellType, mode>(vm);

it's worth a comment here IMO given how this is a bit weird.


More information about the webkit-reviews mailing list