[webkit-reviews] review granted: [Bug 194793] Web Inspector: Provide a way to avoid a recording auto-stop on reload : [Attachment 362343] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194793: Web Inspector: Provide a way to avoid a recording auto-stop on
reload
https://bugs.webkit.org/show_bug.cgi?id=194793

Attachment 362343: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=362343&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 362343
  --> https://bugs.webkit.org/attachment.cgi?id=362343
[PATCH] Proposed Fix

r=me, I've also wanted this!

I think we could potentially iterate on this UI in the future, but it's a good
start. Right now it requires knowing the keyboard shortcut, and pressing
override within a potentially very brief window.

My only comment before landing is to fix the "continue" button appearance in
dark mode. It's current black-on-darkgray.