[webkit-reviews] review granted: [Bug 194675] Move bytecode cache-related filesystem code out of CodeCache : [Attachment 362322] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 18 15:07:36 PST 2019

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 194675: Move bytecode cache-related filesystem code out of CodeCache

Attachment 362322: Patch


--- Comment #20 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362322
  --> https://bugs.webkit.org/attachment.cgi?id=362322

View in context: https://bugs.webkit.org/attachment.cgi?id=362322&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   That code is only used for the bytecode-cache tests, so it should
live in
> +	   jsc.cpp rather than in the CodeCache.

You should make a couple comments about how this changes the interface for

> Source/JavaScriptCore/parser/SourceProvider.h:120
> +	   virtual void cacheBytecode(const BytecodeCacheGenerator&) const { }

I agree this is nicer than the canCache and solves the issue you found.

> Source/JavaScriptCore/runtime/CodeCache.cpp:202
> +    key.source().provider().cacheBytecode([&]() {

style nit: no need for "()"

More information about the webkit-reviews mailing list