[webkit-reviews] review granted: [Bug 194670] [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements : [Attachment 362074] First pass

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 194670: [iOS] Support pasting item-provider-backed data on the pasteboard
as attachment elements
https://bugs.webkit.org/show_bug.cgi?id=194670

Attachment 362074: First pass

https://bugs.webkit.org/attachment.cgi?id=362074&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 362074
  --> https://bugs.webkit.org/attachment.cgi?id=362074
First pass

View in context: https://bugs.webkit.org/attachment.cgi?id=362074&action=review

> Source/WebCore/platform/ios/PasteboardIOS.mm:291
> +	   bool canReadAttachment = policy == WebContentReadingPolicy::AnyType
&& RuntimeEnabledFeatures::sharedFeatures().attachmentElementEnabled();

Maybe put attachmentELementEnabled outside the loop and bail from this whole
section if it's not set?

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:34
> -    typedef std::tuple<WKBundlePageEditorClientV0,
WKBundlePageEditorClientV1, WKBundlePageEditorClientV2> Versions;
> +    typedef std::tuple<WKBundlePageEditorClientV0,
WKBundlePageEditorClientV1> Versions;

Did we ever ship this? I think you noted that nobody adopted, but did we ship
it?