[webkit-reviews] review granted: [Bug 194038] WasmB3IRGenerator models some effects incorrectly : [Attachment 362240] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 17 13:20:30 PST 2019

Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 194038: WasmB3IRGenerator models some effects incorrectly

Attachment 362240: patch


--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 362240
  --> https://bugs.webkit.org/attachment.cgi?id=362240

View in context: https://bugs.webkit.org/attachment.cgi?id=362240&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:-320
> -    patchpoint->append(instanceValue(), ValueRep::SomeRegister);

How did this ever work?... I guess we just usually don’t take this path and/or
B3 rematerialized the value?

More information about the webkit-reviews mailing list