[webkit-reviews] review granted: [Bug 194724] Web Inspector: Move CSS completion logic from SpreadsheetTextField to SpreadsheetStyleProperty : [Attachment 362224] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 194724: Web Inspector: Move CSS completion logic from SpreadsheetTextField
to SpreadsheetStyleProperty
https://bugs.webkit.org/show_bug.cgi?id=194724

Attachment 362224: Patch

https://bugs.webkit.org/attachment.cgi?id=362224&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362224
  --> https://bugs.webkit.org/attachment.cgi?id=362224
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362224&action=review

r=me, nice work :)

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:714
> +	   return {prefix, completions:
WI.CSSCompletions.cssNameCompletions.startsWith(prefix)};

Style: when there are non-simple keys/values, please put all keys/values on
separate lines.

    return {
	prefix,
	completions: WI.CSSCompletions.cssNameCompletions.startsWith(prefix),
    };