[webkit-reviews] review granted: [Bug 193605] Web Inspector: Frontend performance is very slow reloading theverge.com - 50% of time in TreeOutline _indexOfTreeElement : [Attachment 362190] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 16 11:34:04 PST 2019
Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 193605: Web Inspector: Frontend performance is very slow reloading
theverge.com - 50% of time in TreeOutline _indexOfTreeElement
https://bugs.webkit.org/show_bug.cgi?id=193605
Attachment 362190: Patch
https://bugs.webkit.org/attachment.cgi?id=362190&action=review
--- Comment #43 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362190
--> https://bugs.webkit.org/attachment.cgi?id=362190
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=362190&action=review
r=me, nice work :)
Please address my comments on the last patch.
> Source/WebInspectorUI/ChangeLog:74
> + (WI.Table):
NIT: we should probably fix `prepare-ChangeLog` to not generate these :|
> Source/WebInspectorUI/ChangeLog:97
> + (WI.TreeOutline.):
NIT: we should probably fix `prepare-ChangeLog` to not generate these :|
More information about the webkit-reviews
mailing list