[webkit-reviews] review granted: [Bug 194707] pytest is not correctly auto-installed : [Attachment 362119] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 16 02:00:31 PST 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 194707: pytest is not correctly auto-installed
https://bugs.webkit.org/show_bug.cgi?id=194707

Attachment 362119: patch

https://bugs.webkit.org/attachment.cgi?id=362119&action=review




--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 362119
  --> https://bugs.webkit.org/attachment.cgi?id=362119
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362119&action=review

cq- for now just in case there was a good reason to remove that. Please, set
cq+ if it was removed by mistake.

>> Tools/Scripts/webkitpy/thirdparty/__init__.py:162
>> +				  "pytest-3.6.2/src/pytest.py")
> 
> I don't understand. Now it's listed twice, and the only difference is the
missing underscore. Is this really the right way to do it?

This is simple enough, and we are not really downloading twice.


More information about the webkit-reviews mailing list