[webkit-reviews] review requested: [Bug 172848] Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view : [Attachment 362211] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 22:14:41 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 172848: Web Inspector: Improve ES6 Class instances in Heap Snapshot
instances view
https://bugs.webkit.org/show_bug.cgi?id=172848

Attachment 362211: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=362211&action=review




--- Comment #36 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 362211

  --> https://bugs.webkit.org/attachment.cgi?id=362211&action=review

[PATCH] Proposed Fix

After a long long wait, I've gotten back to this again!

• This drive-by fixes JSTexts/heapProfiler.
• Slight cleanup of the old patch
• Fixes the bad `const char*` use by switching to a Set of WTF::Strings


More information about the webkit-reviews mailing list