[webkit-reviews] review granted: [Bug 194739] [LFC] Apply min/max width constraints to preferred width computation : [Attachment 362206] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 194739: [LFC] Apply min/max width constraints to preferred width
computation
https://bugs.webkit.org/show_bug.cgi?id=194739

Attachment 362206: Patch

https://bugs.webkit.org/attachment.cgi?id=362206&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 362206
  --> https://bugs.webkit.org/attachment.cgi?id=362206
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362206&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:309
> +	       auto& formattingState =
layoutState.formattingStateForBox(child);

Could that be const auto&?

> Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp:315
> +	       auto marginBorderAndPadding = 
fixedValue(childStyle.marginStart()).valueOr(0)

Extra space