[webkit-reviews] review granted: [Bug 194735] [JSC] Lazily create empty RegExp : [Attachment 362199] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 15 19:53:40 PST 2019
Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 194735: [JSC] Lazily create empty RegExp
https://bugs.webkit.org/show_bug.cgi?id=194735
Attachment 362199: Patch
https://bugs.webkit.org/attachment.cgi?id=362199&action=review
--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 362199
--> https://bugs.webkit.org/attachment.cgi?id=362199
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=362199&action=review
> Source/JavaScriptCore/runtime/RegExpCache.h:51
> + if (m_emptyRegExp)
Should we mark this likely?
More information about the webkit-reviews
mailing list