[webkit-reviews] review granted: [Bug 194005] AX: Audit tab should have built-in accessibility tests. : [Attachment 362155] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Aaron Chu <aaron_chu at apple.com>'s
request for review:
Bug 194005: AX: Audit tab should have built-in accessibility tests.
https://bugs.webkit.org/show_bug.cgi?id=194005

Attachment 362155: Patch

https://bugs.webkit.org/attachment.cgi?id=362155&action=review




--- Comment #32 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362155
  --> https://bugs.webkit.org/attachment.cgi?id=362155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362155&action=review

r=me, thanks for fixing my NITs

Is there a page that you've been using to test this?  Just for future
reference, we may want to link/attach some page that demonstrates the fact that
these tests work.  Alternatively, you could write a LayoutTest/ManualTest (as a
followup) if you wanted :)

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:828
> +	       if (mainContentElements.length > 1) {

Style: unnecessary brace.

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:835
> +	     let dialogs =
WebInspectorAudit.Accessibility.getElementsByComputedRole("dialog");

Style: indent should be four spaces.