[webkit-reviews] review denied: [Bug 194730] NetworkLoad should cancel its task at destruction time : [Attachment 362176] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 15 16:26:50 PST 2019
Alex Christensen <achristensen at apple.com> has denied review:
Bug 194730: NetworkLoad should cancel its task at destruction time
https://bugs.webkit.org/show_bug.cgi?id=194730
Attachment 362176: Patch
https://bugs.webkit.org/attachment.cgi?id=362176&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 362176
--> https://bugs.webkit.org/attachment.cgi?id=362176
Patch
Nope. We don't want to do this. When the task is destroyed it will
effectively cancel.
What we want to do instead is null check m_client in
NetworkDataTask::shouldCaptureExtraNetworkLoadMetrics
More information about the webkit-reviews
mailing list