[webkit-reviews] review granted: [Bug 194320] Turn On Smart Delete : [Attachment 362151] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 194320: Turn On Smart Delete
https://bugs.webkit.org/show_bug.cgi?id=194320

Attachment 362151: Patch

https://bugs.webkit.org/attachment.cgi?id=362151&action=review




--- Comment #71 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 362151
  --> https://bugs.webkit.org/attachment.cgi?id=362151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362151&action=review

> LayoutTests/resources/ui-helper.js:130
> +	   if (this.isIOS()) {
> +	       await UIHelper.doubleTapAt(x, y);

No curly braces around a single line statement.

> LayoutTests/resources/ui-helper.js:133
> +	   } else {
> +	       await UIHelper.doubleClickAt(x, y);
> +	   }

Ditto.

> LayoutTests/resources/ui-helper.js:140
> +	   var rects = window.getSelection().getRangeAt(0).getClientRects();
> +	   var x = rects[0].left;
> +	   var y = rects[0].top;

Use const.

> LayoutTests/resources/ui-helper.js:149
> +	   } else {
> +	       await UIHelper.doubleClickAt(x, y);
> +	   }

No curly braces around a single line statement.