[webkit-reviews] review denied: [Bug 194723] Disable safe browsing in WKWebView and remove its WKPreferences API : [Attachment 362160] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 14:54:47 PST 2019


Geoffrey Garen <ggaren at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194723: Disable safe browsing in WKWebView and remove its WKPreferences API
https://bugs.webkit.org/show_bug.cgi?id=194723

Attachment 362160: Patch

https://bugs.webkit.org/attachment.cgi?id=362160&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 362160
  --> https://bugs.webkit.org/attachment.cgi?id=362160
Patch

Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65
ata/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPILibrary.bui
ld/Objects-normal/x86_64/ProcessSwapOnNavigation.d --serialize-diagnostics
/Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPIL
ibrary.build/Objects-normal/x86_64/ProcessSwapOnNavigation.dia -c
/Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNav
igation.mm -o
/Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPIL
ibrary.build/Objects-normal/x86_64/ProcessSwapOnNavigation.o
/Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNav
igation.mm:2041:41: error: property 'safeBrowsingEnabled' not found on object
of type 'WKPreferences *'; did you mean '_safeBrowsingEnabled'?
    [webView configuration].preferences.safeBrowsingEnabled = NO;
					^~~~~~~~~~~~~~~~~~~
					_safeBrowsingEnabled
In file included from
/Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNav
igation.mm:35:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WK
PreferencesPrivate.h:146:92: note: '_safeBrowsingEnabled' declared here
@property (nonatomic, getter=_isSafeBrowsingEnabled,
setter=_setSafeBrowsingEnabled:) BOOL _safeBrowsingEnabled
WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));


More information about the webkit-reviews mailing list