[webkit-reviews] review granted: [Bug 194719] Add MSE logging configuration : [Attachment 362154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 14:51:55 PST 2019

Joseph Pecoraro <joepeck at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 194719: Add MSE logging configuration

Attachment 362154: Patch


--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 362154
  --> https://bugs.webkit.org/attachment.cgi?id=362154

View in context: https://bugs.webkit.org/attachment.cgi?id=362154&action=review


> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:93
>		   new WI.ScopeBarItem(WI.LogContentView.Scopes.Media,
WI.UIString("Media"), {className: "media"}),
> +		   new WI.ScopeBarItem(WI.LogContentView.Scopes.Media,
WI.UIString("MediaSource"), {className: "mediasource"}),

So we are re-using the "Media" Scope? I think that is fine.

More information about the webkit-reviews mailing list