[webkit-reviews] review granted: [Bug 194619] Web Inspector: Styles: valid values in style attributes are reported as unsupported property values : [Attachment 362101] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 194619: Web Inspector: Styles: valid values in style attributes are
reported as unsupported property values
https://bugs.webkit.org/show_bug.cgi?id=194619

Attachment 362101: Patch

https://bugs.webkit.org/attachment.cgi?id=362101&action=review




--- Comment #15 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 362101
  --> https://bugs.webkit.org/attachment.cgi?id=362101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362101&action=review

rs=me

>>> LayoutTests/inspector/css/modify-inline-style.html:85
>>> +		    
nodeStyles.addEventListener(WI.DOMNodeStyles.Event.NeedsRefresh,
function(event) {
>>> +			 // Normally, this would get called from views if the
styles sidebar is visible.
>>> +			 // This doesn't work in tests.
>>> +			 event.target.refresh();
>>> +		     });
>> 
>> Joe and I investigated the problem. This fixed test timeouts on WK2. The
rest of the patch is the same as the one that was rolled out.
> 
> Yeah, I really think this is something all of the DOMNodeStyles tests might
want to consider.
> 
> Maybe we should add a TestExtras.js that does something like this, because we
are almost certainly going to forgot to do this in other tests!

I think you should probably do something like this at the top level:

    WI.DOMNodeStyles.addEventListener(WI.DOMNodeStyles.Event.NeedsRefresh,
(event) => {
	event.target.refresh();
    });

So that any DOMNodeStyles that needs a refresh will refresh. Let me know if
that works.