[webkit-reviews] review granted: [Bug 194523] REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is crashing : [Attachment 362085] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 10:22:45 PST 2019


Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194523: REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test
imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is crashing
https://bugs.webkit.org/show_bug.cgi?id=194523

Attachment 362085: Patch

https://bugs.webkit.org/attachment.cgi?id=362085&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 362085
  --> https://bugs.webkit.org/attachment.cgi?id=362085
Patch

> FormCreationContext* formContext =
static_cast<FormCreationContext*>(context);

If you use adoptRef here, you can avoid the manual delete below.

auto formContext = adoptRef(...);
...
callOnMainThread([formContext]) { };


More information about the webkit-reviews mailing list