[webkit-reviews] review granted: [Bug 194666] Make navigator.mediaDevices SecureContext : [Attachment 362076] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 15 09:55:21 PST 2019


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 194666: Make navigator.mediaDevices SecureContext
https://bugs.webkit.org/show_bug.cgi?id=194666

Attachment 362076: Patch

https://bugs.webkit.org/attachment.cgi?id=362076&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 362076
  --> https://bugs.webkit.org/attachment.cgi?id=362076
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362076&action=review

> Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl:35
> +    [SameObject, SecureContext, ContextHasMediaDevices] readonly attribute
MediaDevices mediaDevices;

Nit: I think something like "ContextAllowsMediaDevices" might be clearer.


More information about the webkit-reviews mailing list