[webkit-reviews] review granted: [Bug 194698] [GTK] Crash while filling selection data during drag and drop : [Attachment 362110] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 194698: [GTK] Crash while filling selection data during drag and drop
https://bugs.webkit.org/show_bug.cgi?id=194698

Attachment 362110: Patch

https://bugs.webkit.org/attachment.cgi?id=362110&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 362110
  --> https://bugs.webkit.org/attachment.cgi?id=362110
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362110&action=review

> Source/WebKit/ChangeLog:9
> +	   I can't reproduce this, but it seems that m_draggingSelectionData is
nullptr in fillDragData(). That can happen
> +	   when startDrag cancels a previous DND operation, because the new
m_draggingSelectionData is set before the

Ughhh.

We have another bug here -- somewhere -- that's probably fixed by this. It's a
frequent UI process crasher, and has been for years. I was always stumped
because I didn't realize it was legal for GTK to call startDrag twice in a row
like this. Reminds me to finish work on the similar load events problem we have
right now.