[webkit-reviews] review granted: [Bug 176810] for..in on a Proxy loops over non enumerable properties : [Attachment 360004] (1) [JSC] throw if 'ownKeys' Proxy trap result contains duplicate keys

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 23:30:46 PST 2019


Mark Lam <mark.lam at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 176810: for..in on a Proxy loops over non enumerable properties
https://bugs.webkit.org/show_bug.cgi?id=176810

Attachment 360004: (1) [JSC] throw if 'ownKeys' Proxy trap result contains
duplicate keys

https://bugs.webkit.org/attachment.cgi?id=360004&action=review




--- Comment #56 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 360004
  --> https://bugs.webkit.org/attachment.cgi?id=360004
(1) [JSC] throw if 'ownKeys' Proxy trap result contains duplicate keys

The ownKeys Proxy trap patch LGTM.


More information about the webkit-reviews mailing list