[webkit-reviews] review granted: [Bug 194656] lowerStackArgs should lower Lea32/64 on ARM64 : [Attachment 362086] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 194656: lowerStackArgs should lower Lea32/64 on ARM64
https://bugs.webkit.org/show_bug.cgi?id=194656

Attachment 362086: patch

https://bugs.webkit.org/attachment.cgi?id=362086&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 362086
  --> https://bugs.webkit.org/attachment.cgi?id=362086
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362086&action=review

r=me, I understand the issue, interesting.

> Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:77
> +	       if (isARM64() && (inst.kind.opcode == Lea32 || inst.kind.opcode
== Lea64)) {
> +		   // On ARM64, Lea is just an add. We can't handle this below
because
> +		   // taking into account the Width to see if we can compute
the immediate
> +		   // is wrong.

Should we add some notes in AirOpcode.opcodes? Basically, UA (UseAddr) typed
address would cause a similar problem. (Currently, only LEA uses this type).