[webkit-reviews] review granted: [Bug 192527] Web Inspector: provide a way to make searches case sensitive or use a regular expression : [Attachment 362058] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 192527: Web Inspector: provide a way to make searches case sensitive or use
a regular expression
https://bugs.webkit.org/show_bug.cgi?id=192527

Attachment 362058: Patch

https://bugs.webkit.org/attachment.cgi?id=362058&action=review




--- Comment #15 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 362058
  --> https://bugs.webkit.org/attachment.cgi?id=362058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362058&action=review

r=me

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:190
> +localizedStrings["Case Sensitive"] = "Case Sensitive";

We can include a UIString comment for these strings that they are referring to
different "Text search option"s. I suspect "Regular Expressions" might be
confusing to some localizers.

> Source/WebInspectorUI/UserInterface/Base/SearchUtilities.js:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

Maybe 2019

> Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js:49
> +	   let searchTermLength = textRange.endColumn - textRange.startColumn;

Is it possible that a search may span multiple lines (for a RegExp search for
example?)

What happens if you do a regex search for ".+" how bad are the results?

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:101
> -	   searchQuery = searchQuery.trim();
>	   if (!searchQuery.length)
>	       return;

Does the trim() happen elsewhere or do you want to allow searching for
whitespace?

> LayoutTests/inspector/debugger/search-scripts.html:17
> +    InspectorTest.debug();

Oops