[webkit-reviews] review granted: [Bug 194671] Web Inspector: Occasional crash under WebCore::CSSStyleSheet::item called from Inspector : [Attachment 362059] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194671: Web Inspector: Occasional crash under WebCore::CSSStyleSheet::item
called from Inspector
https://bugs.webkit.org/show_bug.cgi?id=194671

Attachment 362059: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=362059&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362059
  --> https://bugs.webkit.org/attachment.cgi?id=362059
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=362059&action=review

rs=me

> Source/WebCore/ChangeLog:10
> +	   (WebCore::CSSStyleSheet::item):

I think you could add more of the explanation from the bug comments in the
ChangeLog.  Right now, what you have here doesn't really explain "how" this
"might" happen, and what you investigated to arrive at this point.

> Source/WebCore/css/CSSStyleSheet.cpp:234
> +    if (m_childRuleCSSOMWrappers.size() != ruleCount)

NIT: I think it's "smarter" to only expand if we don't have enough room, not if
we don't have exactly the right amount of room.

    if (m_childRuleCSSOMWrappers.size() < ruleCount)