[webkit-reviews] review denied: [Bug 194648] [JSC] LLIntEntryPoint creates same DirectJITCode for all functions : [Attachment 362036] WIP - Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 10:48:52 PST 2019


Mark Lam <mark.lam at apple.com> has denied  review:
Bug 194648: [JSC] LLIntEntryPoint creates same DirectJITCode for all functions
https://bugs.webkit.org/show_bug.cgi?id=194648

Attachment 362036: WIP - Patch

https://bugs.webkit.org/attachment.cgi?id=362036&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362036
  --> https://bugs.webkit.org/attachment.cgi?id=362036
WIP - Patch

This is wrong.	The CTIStub thunks are unique per VM.  You cannot make it a
singleton because it is not shared across VMs.	However, I think you can make
is one instance per VM.


More information about the webkit-reviews mailing list