[webkit-reviews] review denied: [Bug 194614] [WPE][GTK] Clean up handling of WEBKIT_FORCE_COMPLEX_TEXT : [Attachment 361945] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 14 00:58:00 PST 2019

Carlos Garcia Campos <cgarcia at igalia.com> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 194614: [WPE][GTK] Clean up handling of WEBKIT_FORCE_COMPLEX_TEXT

Attachment 361945: Patch


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 361945
  --> https://bugs.webkit.org/attachment.cgi?id=361945

View in context: https://bugs.webkit.org/attachment.cgi?id=361945&action=review

> Source/WebKit/ChangeLog:16
> +	   Also, move this code up to WebKitWebContext and use
> +	   otherwise, setAlwaysUsesComplexTextCodePath doesn't work as

Why not? it has worked so far. That means we can't use it to run layout tests
with complex text enabled/disabled.

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:372
> +    else
> +	   priv->processPool->setAlwaysUsesComplexTextCodePath(true);
> +#endif

I don't like the ifdefs in the middle of an if, I prefer to use a local
variable to define the default value using ifdefs.

More information about the webkit-reviews mailing list