[webkit-reviews] review denied: [Bug 194614] [WPE][GTK] Clean up handling of WEBKIT_FORCE_COMPLEX_TEXT : [Attachment 361945] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 194614: [WPE][GTK] Clean up handling of WEBKIT_FORCE_COMPLEX_TEXT
https://bugs.webkit.org/show_bug.cgi?id=194614

Attachment 361945: Patch

https://bugs.webkit.org/attachment.cgi?id=361945&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 361945
  --> https://bugs.webkit.org/attachment.cgi?id=361945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361945&action=review

> Source/WebKit/ChangeLog:16
> +	   Also, move this code up to WebKitWebContext and use
setAlwaysUsesComplexTextCodePath;
> +	   otherwise, setAlwaysUsesComplexTextCodePath doesn't work as
intended.

Why not? it has worked so far. That means we can't use it to run layout tests
with complex text enabled/disabled.

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:372
> +#if PLATFORM(GTK)
> +    else
> +	   priv->processPool->setAlwaysUsesComplexTextCodePath(true);
> +#endif

I don't like the ifdefs in the middle of an if, I prefer to use a local
variable to define the default value using ifdefs.