[webkit-reviews] review requested: [Bug 167941] [WPE][GTK] Enable support for CONTENT_EXTENSIONS : [Attachment 361981] Patch v8
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 13 18:56:30 PST 2019
Adrian Perez <aperez at igalia.com> has asked for review:
Bug 167941: [WPE][GTK] Enable support for CONTENT_EXTENSIONS
https://bugs.webkit.org/show_bug.cgi?id=167941
Attachment 361981: Patch v8
https://bugs.webkit.org/attachment.cgi?id=361981&action=review
--- Comment #70 from Adrian Perez <aperez at igalia.com> ---
Created attachment 361981
--> https://bugs.webkit.org/attachment.cgi?id=361981&action=review
Patch v8
This version of the patch includes:
- One API test (yay!)
- The renames:
* WebKitContentFilterManager → WebKitUserContentFilterStore
* _compile() → _save()
* _lookup() → _load()
- New webkit_user_content_filter_store_save_from_file() function.
- Content filter errors non-fatal in the MiniBrowsers.
- NULL-check the store path in the constructor.
- Early error return on empty JSON source input.
- Everything should be documented now properly.
Still pending to do before landing:
- Updating the ChangeLogs.
- Make API tests cleanup temporary directories.
- Maybe some new API tests e.g. TestWebKitUserContentFilterStore.
I think this is getting quite close to be ready :)
More information about the webkit-reviews
mailing list