[webkit-reviews] review granted: [Bug 194632] Web Inspector: Crash when inspecting an element that constantly changes visibility : [Attachment 361978] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194632: Web Inspector: Crash when inspecting an element that constantly
changes visibility
https://bugs.webkit.org/show_bug.cgi?id=194632

Attachment 361978: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=361978&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 361978
  --> https://bugs.webkit.org/attachment.cgi?id=361978
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361978&action=review

r=me

> Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:1746
> +void InspectorDOMAgent::processAccessibilityChildren(AccessibilityObject&
axObject, JSON::ArrayOf<int>& childNodeIds)

This can be const AccessibilityObject&, since the children method is const.