[webkit-reviews] review granted: [Bug 194623] Web Inspector: don't include accessibility role in DOM.Node object payloads : [Attachment 361957] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 13 16:39:49 PST 2019
Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 194623: Web Inspector: don't include accessibility role in DOM.Node object
payloads
https://bugs.webkit.org/show_bug.cgi?id=194623
Attachment 361957: Patch
https://bugs.webkit.org/attachment.cgi?id=361957&action=review
--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 361957
--> https://bugs.webkit.org/attachment.cgi?id=361957
Patch
r=me
We should also update `WI.DOMNode.prototype.accessibilityProperties` to save
the role to `_computedRole` so that `WI.DOMNode.prototype.computedRole`
actually returns a value once we've requested accessibility info at least once
(this is needed by `WI.roleSelectorForNode`).
More information about the webkit-reviews
mailing list